Merge pull request #1129 from crazy-max/fix-docker-context

check context builder endpoint
pull/1011/head
CrazyMax 2 years ago committed by GitHub
commit 0078390934
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -65,11 +65,20 @@ func driversForNodeGroup(ctx context.Context, dockerCli command.Cli, ng *store.N
return nil, errors.Errorf("failed to find driver %q", f) return nil, errors.Errorf("failed to find driver %q", f)
} }
} else { } else {
// empty driver means nodegroup was implicitly created as a default
// driver for a docker context and allows falling back to a
// docker-container driver for older daemon that doesn't support
// buildkit (< 18.06).
ep := ng.Nodes[0].Endpoint ep := ng.Nodes[0].Endpoint
dockerapi, err := clientForEndpoint(dockerCli, ep) dockerapi, err := clientForEndpoint(dockerCli, ep)
if err != nil { if err != nil {
return nil, err return nil, err
} }
// check if endpoint is healthy is needed to determine the driver type.
// if this fails then can't continue with driver selection.
if _, err = dockerapi.Ping(ctx); err != nil {
return nil, err
}
f, err = driver.GetDefaultFactory(ctx, ep, dockerapi, false) f, err = driver.GetDefaultFactory(ctx, ep, dockerapi, false)
if err != nil { if err != nil {
return nil, err return nil, err

Loading…
Cancel
Save