build: improve error messages for docker driver
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com> Co-authored-by: CrazyMax <crazy-max@users.noreply.github.com>
This commit is contained in:
@@ -391,7 +391,7 @@ func toSolveOpt(ctx context.Context, node builder.Node, multiDriver bool, opt Op
|
|||||||
|
|
||||||
for _, e := range opt.CacheTo {
|
for _, e := range opt.CacheTo {
|
||||||
if e.Type != "inline" && !nodeDriver.Features(ctx)[driver.CacheExport] {
|
if e.Type != "inline" && !nodeDriver.Features(ctx)[driver.CacheExport] {
|
||||||
return nil, nil, notSupported(nodeDriver, driver.CacheExport)
|
return nil, nil, cacheExportNotSupported(nodeDriver)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -529,7 +529,7 @@ func toSolveOpt(ctx context.Context, node builder.Node, multiDriver bool, opt Op
|
|||||||
// set up exporters
|
// set up exporters
|
||||||
for i, e := range opt.Exports {
|
for i, e := range opt.Exports {
|
||||||
if e.Type == "oci" && !nodeDriver.Features(ctx)[driver.OCIExporter] {
|
if e.Type == "oci" && !nodeDriver.Features(ctx)[driver.OCIExporter] {
|
||||||
return nil, nil, notSupported(nodeDriver, driver.OCIExporter)
|
return nil, nil, exporterNotSupported(nodeDriver, driver.OCIExporter)
|
||||||
}
|
}
|
||||||
if e.Type == "docker" {
|
if e.Type == "docker" {
|
||||||
features := docker.Features(ctx, e.Attrs["context"])
|
features := docker.Features(ctx, e.Attrs["context"])
|
||||||
@@ -555,7 +555,7 @@ func toSolveOpt(ctx context.Context, node builder.Node, multiDriver bool, opt Op
|
|||||||
opt.Exports[i].Output = wrapWriteCloser(w)
|
opt.Exports[i].Output = wrapWriteCloser(w)
|
||||||
}
|
}
|
||||||
} else if !nodeDriver.Features(ctx)[driver.DockerExporter] {
|
} else if !nodeDriver.Features(ctx)[driver.DockerExporter] {
|
||||||
return nil, nil, notSupported(nodeDriver, driver.DockerExporter)
|
return nil, nil, exporterNotSupported(nodeDriver, driver.DockerExporter)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if e.Type == "image" && nodeDriver.IsMobyDriver() {
|
if e.Type == "image" && nodeDriver.IsMobyDriver() {
|
||||||
@@ -627,7 +627,7 @@ func toSolveOpt(ctx context.Context, node builder.Node, multiDriver bool, opt Op
|
|||||||
pp[i] = platforms.Format(p)
|
pp[i] = platforms.Format(p)
|
||||||
}
|
}
|
||||||
if len(pp) > 1 && !nodeDriver.Features(ctx)[driver.MultiPlatform] {
|
if len(pp) > 1 && !nodeDriver.Features(ctx)[driver.MultiPlatform] {
|
||||||
return nil, nil, notSupported(nodeDriver, driver.MultiPlatform)
|
return nil, nil, multiPlatformBuildNotSupported(nodeDriver)
|
||||||
}
|
}
|
||||||
so.FrontendAttrs["platform"] = strings.Join(pp, ",")
|
so.FrontendAttrs["platform"] = strings.Join(pp, ",")
|
||||||
}
|
}
|
||||||
@@ -1560,8 +1560,22 @@ func waitContextDeps(ctx context.Context, index int, results *waitmap.Map, so *c
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func notSupported(d driver.Driver, f driver.Feature) error {
|
func cacheExportNotSupported(d driver.Driver) error {
|
||||||
return errors.Errorf("%s feature is currently not supported for %s driver. Please switch to a different driver (eg. \"docker buildx create --use\")", f, d.Factory().Name())
|
return errors.Errorf(`Cache export is not supported for the %s driver.
|
||||||
|
Switch to a different driver and try again.
|
||||||
|
Learn more at https://docs.docker.com/go/build-cache-backends/`, d.Factory().Name())
|
||||||
|
}
|
||||||
|
|
||||||
|
func exporterNotSupported(d driver.Driver, f driver.Feature) error {
|
||||||
|
return errors.Errorf(`%s is not supported for the %s driver.
|
||||||
|
Switch to a different driver and try again.
|
||||||
|
Learn more at https://docs.docker.com/go/build-exporters/`, f, d.Factory().Name())
|
||||||
|
}
|
||||||
|
|
||||||
|
func multiPlatformBuildNotSupported(d driver.Driver) error {
|
||||||
|
return errors.Errorf(`Multi-platform build is not supported for the %s driver without the containerd image store.
|
||||||
|
Switch to a different driver, or turn on the containerd image store, and try again.
|
||||||
|
Learn more at https://docs.docker.com/go/build-multi-platform/`, d.Factory().Name())
|
||||||
}
|
}
|
||||||
|
|
||||||
func noDefaultLoad() bool {
|
func noDefaultLoad() bool {
|
||||||
|
|||||||
@@ -40,6 +40,9 @@ var buildTests = []func(t *testing.T, sb integration.Sandbox){
|
|||||||
testBuildMobyFromLocalImage,
|
testBuildMobyFromLocalImage,
|
||||||
testBuildDetailsLink,
|
testBuildDetailsLink,
|
||||||
testBuildProgress,
|
testBuildProgress,
|
||||||
|
testBuildCacheExportNotSupported,
|
||||||
|
testBuildOCIExportNotSupported,
|
||||||
|
testBuildMultiPlatformNotSupported,
|
||||||
}
|
}
|
||||||
|
|
||||||
func testBuild(t *testing.T, sb integration.Sandbox) {
|
func testBuild(t *testing.T, sb integration.Sandbox) {
|
||||||
@@ -313,3 +316,39 @@ func testBuildProgress(t *testing.T, sb integration.Sandbox) {
|
|||||||
require.Contains(t, string(plainOutput), "[internal] load build definition from Dockerfile")
|
require.Contains(t, string(plainOutput), "[internal] load build definition from Dockerfile")
|
||||||
require.Contains(t, string(plainOutput), "[base 1/3] FROM docker.io/library/busybox:latest")
|
require.Contains(t, string(plainOutput), "[base 1/3] FROM docker.io/library/busybox:latest")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func testBuildCacheExportNotSupported(t *testing.T, sb integration.Sandbox) {
|
||||||
|
if sb.Name() != "docker" {
|
||||||
|
t.Skip("skipping test for non-docker workers")
|
||||||
|
}
|
||||||
|
|
||||||
|
dir := createTestProject(t)
|
||||||
|
cmd := buildxCmd(sb, withArgs("build", "--cache-to=type=registry", dir))
|
||||||
|
out, err := cmd.CombinedOutput()
|
||||||
|
require.Error(t, err, string(out))
|
||||||
|
require.Contains(t, string(out), "Cache export is not supported")
|
||||||
|
}
|
||||||
|
|
||||||
|
func testBuildOCIExportNotSupported(t *testing.T, sb integration.Sandbox) {
|
||||||
|
if sb.Name() != "docker" {
|
||||||
|
t.Skip("skipping test for non-docker workers")
|
||||||
|
}
|
||||||
|
|
||||||
|
dir := createTestProject(t)
|
||||||
|
cmd := buildxCmd(sb, withArgs("build", fmt.Sprintf("--output=type=oci,dest=%s/result", dir), dir))
|
||||||
|
out, err := cmd.CombinedOutput()
|
||||||
|
require.Error(t, err, string(out))
|
||||||
|
require.Contains(t, string(out), "OCI exporter is not supported")
|
||||||
|
}
|
||||||
|
|
||||||
|
func testBuildMultiPlatformNotSupported(t *testing.T, sb integration.Sandbox) {
|
||||||
|
if sb.Name() != "docker" {
|
||||||
|
t.Skip("skipping test for non-docker workers")
|
||||||
|
}
|
||||||
|
|
||||||
|
dir := createTestProject(t)
|
||||||
|
cmd := buildxCmd(sb, withArgs("build", "--platform=linux/amd64,linux/arm64", dir))
|
||||||
|
out, err := cmd.CombinedOutput()
|
||||||
|
require.Error(t, err, string(out))
|
||||||
|
require.Contains(t, string(out), "Multi-platform build is not supported")
|
||||||
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user