From 77e0e860f8fbded9feceb1914234f0d3cfa32f88 Mon Sep 17 00:00:00 2001 From: Justin Chadwell Date: Wed, 10 May 2023 09:50:31 +0100 Subject: [PATCH] controller: default to using local controller --detach shouldn't be the default yet, since it still has the potential to leak some sessions in odd edge cases, and is slightly more painful to debug. For now, we should set the local controller as the default, with the idea that we can change it back in the future. Signed-off-by: Justin Chadwell --- commands/build.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/commands/build.go b/commands/build.go index dac4e76f..1a1e6a78 100644 --- a/commands/build.go +++ b/commands/build.go @@ -11,7 +11,6 @@ import ( "log" "os" "path/filepath" - "runtime" "strconv" "strings" @@ -496,7 +495,7 @@ func buildCmd(dockerCli command.Cli, rootOpts *rootOptions) *cobra.Command { if isExperimental() { flags.StringVar(&invokeFlag, "invoke", "", "Invoke a command after the build [experimental]") flags.StringVar(&options.Root, "root", "", "Specify root directory of server to connect [experimental]") - flags.BoolVar(&options.Detach, "detach", runtime.GOOS == "linux", "Detach buildx server (supported only on linux) [experimental]") + flags.BoolVar(&options.Detach, "detach", false, "Detach buildx server (supported only on linux) [experimental]") flags.StringVar(&options.ServerConfig, "server-config", "", "Specify buildx server config file (used only when launching new server) [experimental]") }