From 7a227bd2e68ccd1e9941f79c12fceb7a0a896d3c Mon Sep 17 00:00:00 2001 From: Michal Augustyn Date: Sat, 29 May 2021 13:57:45 +0200 Subject: [PATCH] fixes #617: change delimeter for nodeselector Signed-off-by: Michal Augustyn --- docs/reference/buildx_create.md | 2 +- driver/kubernetes/factory.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/reference/buildx_create.md b/docs/reference/buildx_create.md index 28a68798..5d4c560f 100644 --- a/docs/reference/buildx_create.md +++ b/docs/reference/buildx_create.md @@ -125,7 +125,7 @@ Passes additional driver-specific options. Details for each driver: - `image=IMAGE` - Sets the container image to be used for running buildkit. - `namespace=NS` - Sets the Kubernetes namespace. Defaults to the current namespace. - `replicas=N` - Sets the number of `Pod` replicas. Defaults to 1. - - `nodeselector="label1=value1,label2=value2"` - Sets the kv of `Pod` nodeSelector. No Defaults. Example `nodeselector=kubernetes.io/arch=arm64` + - `nodeselector="label1=value1;label2=value2"` - Sets the kv of `Pod` nodeSelector. No Defaults. Use `;` to split labels. Example `nodeselector=kubernetes.io/arch=arm64` - `rootless=(true|false)` - Run the container as a non-root user without `securityContext.privileged`. [Using Ubuntu host kernel is recommended](https://github.com/moby/buildkit/blob/master/docs/rootless.md). Defaults to false. - `loadbalance=(sticky|random)` - Load-balancing strategy. If set to "sticky", the pod is chosen using the hash of the context path. Defaults to "sticky" diff --git a/driver/kubernetes/factory.go b/driver/kubernetes/factory.go index de69f374..18883d61 100644 --- a/driver/kubernetes/factory.go +++ b/driver/kubernetes/factory.go @@ -92,7 +92,7 @@ func (f *factory) New(ctx context.Context, cfg driver.InitConfig) (driver.Driver } deploymentOpt.Image = bkimage.DefaultRootlessImage case "nodeselector": - kvs := strings.Split(strings.Trim(v, `"`), ",") + kvs := strings.Split(strings.Trim(v, `"`), ";") s := map[string]string{} for i := range kvs { kv := strings.Split(kvs[i], "=")