Justin Chadwell
d4a2c8d0c3
dockerutil: cache feature collection
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Justin Chadwell
bef42b2441
Merge pull request #1876 from tonistiigi/remove-history-request
2 years ago
CrazyMax
2de333fdd3
check history api support once
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2 years ago
Tonis Tiigi
1138789f20
avoid extra client for history API detection
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2 years ago
Justin Chadwell
1f4ac09ffb
Merge pull request #1874 from thaJeztah/bump_engine_24.0.2
2 years ago
CrazyMax
26a8ffb393
Merge pull request #1873 from jedevc/vendor-buildkit-master
...
vendor: update buildkit to master@67a08623b95a
2 years ago
CrazyMax
9b7aada99b
Merge pull request #1716 from distorhead/use-docker-cli-in-stream
...
build(cli): allow passing in-stream using command.Cli
2 years ago
Sebastiaan van Stijn
fd6207695b
vendor: github.com/docker/cli v24.0.2
...
no changes in vendored files
full diff: https://github.com/docker/cli/compare/v24.0.1...v24.0.2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2 years ago
Sebastiaan van Stijn
def96d2bf4
vendor: github.com/docker/docker v24.0.2
...
no changes in vendored files
full diff: https://github.com/docker/docker/compare/v24.0.1...v24.0.2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2 years ago
Justin Chadwell
f5f00e68ef
bake(cli): allow passing in-stream using command.Cli
...
ReadLocalFiles should allow passing the stdin file as an argument, which
allows us to read from dockerCli.Stdin() to be consistent with other
commands in the same package.
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Justin Chadwell
14aebe713e
debug-shell(cli): allow passing in-stream using command.Cli
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Justin Chadwell
9d2388e6f5
vendor: update buildkit to master@67a08623b95a
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Timofey Kirillov
75e2c46295
build(cli): allow passing in-stream using command.Cli
...
Use command.Cli::In() which is always initialized either to os.Stdin, or to user-specified stream:
* 5be21394cb/cli/command/cli.go (L494)
* https://github.com/docker/cli/blob/master/cli/command/cli_options.go#L16C1-L26
Signed-off-by: Timofey Kirillov <timofey.kirillov@flant.com>
2 years ago
Justin Chadwell
2c02db8db4
Merge pull request #1835 from ktock/long-form-json
2 years ago
Kohei Tokunaga
e304a05d2a
docs: monitor: mention about long form flag
...
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
2 years ago
Kohei Tokunaga
14c1ea0e11
invoke: Allow JSON array for long form flags
...
This commit allows specifying a JSON array to the long-form arg, entrypoint and
envvars.
Non-JSON-array value can still be specified. Buildx treats the value as a JSON
array only when it can be parsed as a JSON array.
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
2 years ago
Justin Chadwell
c30bcade2c
Merge pull request #1870 from tianon/invoke-entrypoint-fixes
2 years ago
Tianon Gravi
62bfb19db4
Fix a couple `--invoke` entrypoint interaction bugs
...
When running `--invoke` against images that have `Cmd` set, the interactions with `Entrypoint` start to cause issues like the following:
/usr/local/bin/bash: /usr/local/bin/bash: cannot execute binary file
Or:
sh: can't open 'bash': No such file or directory
This patch fixes those by explicitly setting `Cmd` to be empty if it is unspecified and `Entrypoint` is being set, which matches `docker`'s behavior:
$ docker image inspect --format '{{ json .Config.Entrypoint }} + {{ json .Config.Cmd }}' bash
["docker-entrypoint.sh"] + ["bash"]
$ docker create --name foo --entrypoint bash bash
$ docker container inspect --format '{{ json .Config.Entrypoint }} + {{ json .Config.Cmd }}' foo
["bash"] + null
$ docker rm foo
$ docker create --name foo bash ls
$ docker container inspect --format '{{ json .Config.Entrypoint }} + {{ json .Config.Cmd }}' foo
["docker-entrypoint.sh"] + ["ls"]
(There are still some weird edge cases in the interaction between the `InvokeConfig` and the original image config, but this fixes the most irritating for me and the rest are going to be deeper changes that are possibly less acceptable. 😅 )
Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
2 years ago
Justin Chadwell
47e34f2684
Merge pull request #1813 from jedevc/oci-export-on-containerd
2 years ago
Justin Chadwell
3d981be4ad
Merge pull request #1850 from ktock/monitor-longhelp
2 years ago
CrazyMax
5d94b0fcc7
Merge pull request #1866 from crazy-max/bump-compose
...
vendor: github.com/compose-spec/compose-go v1.14.0
2 years ago
CrazyMax
569c66fb62
Merge pull request #1867 from crazy-max/bump-testify
...
vendor: github.com/stretchr/testify v1.8.4
2 years ago
CrazyMax
93f7fbdd78
Merge pull request #1865 from crazy-max/bump-semver
...
vendor: github.com/Masterminds/semver/v3 v3.2.1
2 years ago
Tõnis Tiigi
ea06685c11
Merge pull request #1858 from potherca-contrib/fix/typo-Shortand
...
Fix typo "Shortand" -> "Shorthand"
2 years ago
Ben Peachey
eaba4fa9e6
Update docs with result from `make docs` command.
...
Signed-off-by: Ben Peachey <potherca@gmail.com>
2 years ago
CrazyMax
99e3882e2a
Merge pull request #1841 from crazy-max/desktop
...
build: display build details link
2 years ago
CrazyMax
0a2f35970c
build: display build details link
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2 years ago
CrazyMax
ab5f5e4169
build: fix quiet mode
...
We are using the quiet flag option and we are not taking
progress quiet mode into account
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2 years ago
Justin Chadwell
696770d29c
Merge pull request #1840 from jedevc/fix-check-path-for-bake-cmd-context
2 years ago
CrazyMax
b47b4e5957
vendor: github.com/stretchr/testify v1.8.4
...
full diff https://github.com/stretchr/testify/compare/v1.8.2...v1.8.4
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2 years ago
CrazyMax
9a125afba0
vendor: github.com/compose-spec/compose-go v1.14.0
...
https: //github.com/compose-spec/compose-go/compare/v1.13.4...v1.14.0
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2 years ago
Justin Chadwell
d34103b0d9
bake: fix potential context entitlements escape
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Justin Chadwell
c820350b5e
tests: refactor cmd helpers to allow configuring cwd, etc
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Justin Chadwell
61a7854659
tests: add bake test for remote subdir context
...
Fixed in 12b6a3ad9a
, but now we have
regression tests! So we can add a check that we don't break this
behavior again.
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Justin Chadwell
e859ebc12e
tests: add bake test for remote cmd context override
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Justin Chadwell
ef997fd6d0
bake: fix BAKE_CMD_CONTEXT relative path resolution
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Justin Chadwell
76c96347ff
tests: add basic remote bake context test
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Justin Chadwell
48d7dafbd5
git: update gitutil test utilities
...
- Adds a new GitServeHTTP function to start an http server to serve a
target git repository.
- Adds a new GitDir helper method to get the path to the .git
directory
- Updates the GitAdd method to take a variable number of files
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Justin Chadwell
d03e93f6f1
test: tmpdir can be a test helper
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Justin Chadwell
fcb7810a38
Merge pull request #1854 from crazy-max/inspect-features
2 years ago
CrazyMax
459d94bdf1
vendor: github.com/Masterminds/semver/v3 v3.2.1
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2 years ago
Justin Chadwell
7cef021a8a
Merge pull request #1804 from jedevc/fixup-solve
2 years ago
Justin Chadwell
c6db4cf342
build: clarify NewResultHandle comment
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
CrazyMax
6c9436fbd5
inspect: display builder features
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2 years ago
Justin Chadwell
a906149930
Merge pull request #1862 from jedevc/update-contributing-tests
...
docs: update CONTRIBUTING.md with specific test notes
2 years ago
Justin Chadwell
af328fe413
docs: update CONTRIBUTING.md with specific test notes
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Justin Chadwell
183a73abae
build: docker exporter should instead use oci with containerd
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Justin Chadwell
b7f0b3d763
build: clear exports for secondary solve request
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Justin Chadwell
5b27d5a9f6
build: cleanup res if returned in basic build
...
In practice, this shouldn't happen, but the check is good to include
anyways.
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
Ben Peachey
8f24c58f4d
Fix typo in commands/build.go and docs/reference/buildx_build.md
...
`Shortand` -> `Shorthand`
Signed-off-by: Ben Peachey <potherca@gmail.com>
2 years ago