ef0cbf20f4
buildx: warn on editing nodes
...
Previously, editing nodes to contain a new set of driver options or
config files was unsupported, and silently dropping them. In this patch,
we update with these, as well as add a new warning message that any new
options may not taken into account until the builder restarts (which
may apply to the flags, platforms and endpoints as well).
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
0defb614a4
docker api: use helper to parse context docker endpoint metadata
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2 years ago
febcc25d1a
prune: fix filter until option
...
Previously, when specifying the filter option with the until value, no
cache would be cleaned, preventing users from clearing by time. This bug
arises from passing the until field through into buildkit, where, on
filtering, a non-existent field returns false for a match.
The fix is simple, as we build up our list of filters to pass to
buildkit, we skip over the until key, so create a valid list of filters
for buildkit.
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
3f5974b7f9
buildx: forbid mismatched drivers
...
This patch reorders+refactors the runCreate function to ensure that we
can detect and notify the user in the scenario that the user attempts to
combine multiple drivers in a single builder, which is an unsupported
scenario.
Previously, we would just overwrite the previous builder with the new
driver, potentially invalidating the already existing nodes.
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
7ab3dc080b
kubernetes: error about unused endpoint argument
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
1f6612b118
Merge pull request #1137 from jedevc/imagetools-multiple-repositories
...
Imagetools multiple repositories
2 years ago
c1fbebe73f
Merge pull request #1206 from jedevc/init-builder-errors
...
buildx: log errors in initializing builders
2 years ago
7ef679d945
bake(compose): allow dot in target name
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2 years ago
e27a5966ef
check context builder endpoint
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2 years ago
4ecca34a42
imagetools: give imagetools create a progress bar
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
37ca8631f9
imagetools: copy manifests between repositories
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
d3412f1039
imagetools: refactor combining repository logic
...
This patch modifies the existing combining code in imagetools create to
provide better support for multiple repositories down the road.
Specifically, the code should no longer rely on a single repository
being used for all sources and tags, and should resolve descriptors in
their relevant repositories.
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
86825a95ce
buildx: rollback configuration if create fails
...
This builds on the added warnings from initialized builders, now
erroring the command, and additionally attempting to revert to the
previous configuration.
To preserve the previous configuration, we add a deep Copy() function to
the NodeGroup and Node so that we can easily restore it later if we
encounter a failure.
Signed-off-by: Justin Chadwell <me@jedevc.com>
2 years ago
309c49413c
buildx: log errors in initializing builders
...
Previously, errors within the driver config would not be reported to the
user until they tried to use the driver, even though they are easily
accessible from the node group info.
This patch reports these errors (but will not fail because of them,
since the data is already saved) - this should help improve
debuggability of some of the more complex drivers, and prevent error
messages being suppressed.
Signed-off-by: Justin Chadwell <me@jedevc.com>
3 years ago
3b4780ef19
vendor: bump buildkit to master
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
3 years ago
a8bb25d1b5
Merge pull request #1168 from ktock/invoke
...
Add `--invoke` option to launch a container from the build result
3 years ago
387e1ecca6
Add `--invoke` option to launch a container from the build result
...
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
3 years ago
0295555a5a
Merge pull request #1109 from crazy-max/ls-progress
...
ls: move builder/node status error msg below table
3 years ago
71e4a39ae9
Merge pull request #1134 from jedevc/remote-driver-connhelpers
...
Remote driver connhelpers
3 years ago
1eff9310f8
remote: add additional connhelpers to buildx
...
Signed-off-by: Justin Chadwell <me@jedevc.com>
3 years ago
064bd92583
ls: move builder/node status error msg below table
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
d611bbe609
rm: display name of removed builder
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
1e71a3ffa7
rm: disallow removing context builders
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
69d95cc847
create: warn if instance name already exists as context builder
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
78ae826d74
ls: dedup instances from store and context
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
8257a04a7d
create: load default buildkit config if none specified
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
57156ee95c
ls: adds fallback if buildkit version info unimplemented
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
6e3babc461
ls: display buildkit version of the nodes
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
92009ed03c
Merge pull request #1085 from tonistiigi/closeread-ignore
...
root: ignore SSH CloseRead warning
3 years ago
72758fef22
root: ignore SSH CloseRead warning
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
d7e4affe98
Complete remote driver
...
This patch completes the work started in creating a remote driver:
- Renames the env driver to the remote driver (an alternative suggestion
that should be more user-friendly)
- Adds support for TLS to encrypt connections with buildkitd
- Fixes outstanding review comments
- Reworks the buildx create command endpoint construction to be clearer
and include better support for this new driver.
Signed-off-by: Justin Chadwell <me@jedevc.com>
3 years ago
3dc83e5dd8
feat: env driver
...
Co-authored-by: Furkan Türkal <furkan.turkal@trendyol.com>
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
3 years ago
95086cf641
cli: fix standalone command behavior
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
4a226568a0
Fix tolerations not parsing its options correctly, add tests
...
Signed-off-by: Zsolt <zsolt.szeberenyi@figured.com>
3 years ago
04b44b3a89
imagetools: respect --builder flag
...
The --builder flag was being ignored by imagetools because of pointer
problems. Essentially, because the root cmds aren't parsed immediately,
we need to pass a pointer to the builder string so that it can be
updated before the RunE function gets called.
Signed-off-by: Justin Chadwell <me@jedevc.com>
3 years ago
082c83b825
inspect: fix printing of driver options
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
1ca30a58c2
Merge pull request #1003 from developer-guy/feature/1001
...
feat: printing driver options
3 years ago
da4c27e9af
feat: printing driver options
...
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
3 years ago
fc7ba75fd7
Remove uses of deprecated io/ioutil
...
The package has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
3 years ago
c255c04eed
bake: restore consistent output for metadata
...
Metadata formatting should not depend on the number
of targets.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
6efcee28d5
Merge pull request #973 from crazy-max/vendor-docker-cli
...
vendor: update docker/cli to 8667ccd
3 years ago
971b5d2b73
vendor: update docker/cli to 8667ccd
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
94c5dde85a
docs: small fixes
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
7af29802d4
Merge pull request #854 from crazy-max/buildinfo-cmd
...
imagetools inspect: add --format flag
3 years ago
6ac01ec9ac
Merge pull request #965 from tonistiigi/bake-context-validation
...
bake: additional support for named context on remote inputs
3 years ago
20a55e9184
imagetools inspect: multi-platform support
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
6c56109083
imagetools inspect: add --format flag
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
280c008f81
bake: make named contexts relative to remote bake input
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
b5bf28d722
bake: use better error in named contexts not supported
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
e98a476dc8
set build-args from docker proxy configuration
...
For backward compatibility with docker build.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
230dfa96a3
docs: built-in build args
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
eef6deb7c2
Merge pull request #860 from tonistiigi/no-cache-filter
...
build: add no-cache-filter
3 years ago
e5f590a7fa
Merge pull request #946 from crazy-max/metadata-output
...
build: enhance metadata json output
3 years ago
299fd19c49
build: enhance metadata json output
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
eb8057e8e0
forbid setting no-cache and no-cache-filter together
...
Per review request.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
3b47722032
build: add no-cache-filter
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
b39ebab666
docs: secret usage examples
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
2d7540fb0a
Separate io.Writer from console.File for NewPrinter
...
Signed-off-by: Edgar Lee <edgarl@netflix.com>
3 years ago
595285736c
Merge pull request #885 from crazy-max/rm-inactive
...
cli: add --all-inactive for rm command
3 years ago
378f0b45c6
cli: add --all-inactive and --force flags for rm command
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
6c69d970f7
Merge pull request #924 from crazy-max/log
...
root: filter out useless commandConn.CloseWrite warning message
3 years ago
d3e56ea9d9
root: simple output format on logrus for parity with cli
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
278f94a8b6
root: filter out useless commandConn.CloseWrite warning message
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
f37c253ae4
commands: provide more helpful error when —build-context is not supported
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
d77e2453da
commands: rename context flag to build-context
...
Avoid conflicts with docker context
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
de6b04d726
build: add support for named contexts
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
038727477c
root: filter out useless debug logs from vendored packages
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
ed4103ef52
commands: build summary of warnings on build
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
9c3be32bc9
vendor: update buildkit to 539be170
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
9aff9301ce
disk usage: last accessed not displayed
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
316ca972b6
bake: fix print output
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
cc2a879660
commands: clean up unnecessary code
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
89334a88a9
Merge pull request #853 from crazy-max/fix-flags
...
cli: fix flags usage
3 years ago
72dab552b5
Add an option to buildx rm to keep the buildkitd daemon running
...
Add --keep-daemon to the `rm` command option to preserve the buildkitd daemon after the buildx context is deleted.
Signed-off-by: Mayeul Blanzat <mayeul.blanzat@datadoghq.com>
3 years ago
a0a7db127c
cli: fix flags usage
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
eab0e6a8fe
cli: fix builder persistent flag
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
88d0775692
refactor accessing registry configs via drivers
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
8afc82b427
Merge pull request #817 from tonistiigi/project-sharedkey
...
build: set local sharedkey per project basename
3 years ago
4c1621cccd
store snapshot of config files on create
...
Files can be reused when container needs to be booted again.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
aa52a5a699
build: set local sharedkey per project basename
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
dd15969c93
build: add cgroup-parent support
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
25d2f73858
build: warning on deprecated flags
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
36a37a624e
refactor: flags lexical order
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
e150d7bdd8
add long description to root command
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
8e5595b7c7
build: add shm-size support
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
b89e2f35df
build: add ulimit support
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
9e62c9f074
Fix --driver flag usage markdown output
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
0cea838344
Merge pull request #773 from tonistiigi/bake-push-fix
...
bake: fix using push override with output definition
3 years ago
2b18a9b4a5
Merge pull request #761 from morlay/kubeconfig-enhance
...
util: support load Colon-separated KUBECONFIG
3 years ago
6fc906532b
bake: fix using push override with output definition
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
c83812144c
util: support load Colon-separated KUBECONFIG
...
Signed-off-by: Morlay <morlay.null@gmail.com>
3 years ago
b05c313204
Merge pull request #740 from bossmc/support-quiet
...
Implement `--quiet` support
3 years ago
8a12884814
Fix flags usage markdown output
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
55a3ce606f
Built-in variable `BAKE_LOCAL_PLATFORM`
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
ef3e46fd62
Move printing to stdout up to the command itself
...
Signed-off-by: Andy Caldwell <andrew.caldwell@metaswitch.com>
3 years ago
c19c018a4c
Implement `--quiet` support
...
Signed-off-by: Andy Caldwell <andrew.caldwell@metaswitch.com>
3 years ago
422ba60b04
use long-running context for client initialization
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 years ago
04bac63745
Merge pull request #692 from crazy-max/boostrap-cmd
...
Allow booting builder after creation
3 years ago
c685e46609
bake: print default group
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
5d50bd7b43
Allow booting builder after creation
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3 years ago
Justin Chadwell