You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
62bfb19db4
When running `--invoke` against images that have `Cmd` set, the interactions with `Entrypoint` start to cause issues like the following:
/usr/local/bin/bash: /usr/local/bin/bash: cannot execute binary file
Or:
sh: can't open 'bash': No such file or directory
This patch fixes those by explicitly setting `Cmd` to be empty if it is unspecified and `Entrypoint` is being set, which matches `docker`'s behavior:
$ docker image inspect --format '{{ json .Config.Entrypoint }} + {{ json .Config.Cmd }}' bash
["docker-entrypoint.sh"] + ["bash"]
$ docker create --name foo --entrypoint bash bash
$ docker container inspect --format '{{ json .Config.Entrypoint }} + {{ json .Config.Cmd }}' foo
["bash"] + null
$ docker rm foo
$ docker create --name foo bash ls
$ docker container inspect --format '{{ json .Config.Entrypoint }} + {{ json .Config.Cmd }}' foo
["docker-entrypoint.sh"] + ["ls"]
(There are still some weird edge cases in the interaction between the `InvokeConfig` and the original image config, but this fixes the most irritating for me and the rest are going to be deeper changes that are possibly less acceptable. 😅)
Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
|
2 years ago | |
|---|---|---|
| .. | ||
| imagetools | 3 years ago | |
| bake.go | 2 years ago | |
| build.go | 2 years ago | |
| create.go | 3 years ago | |
| create_test.go | 4 years ago | |
| debug-shell.go | 3 years ago | |
| diskusage.go | 3 years ago | |
| inspect.go | 2 years ago | |
| install.go | 3 years ago | |
| ls.go | 3 years ago | |
| prune.go | 3 years ago | |
| rm.go | 3 years ago | |
| root.go | 3 years ago | |
| stop.go | 3 years ago | |
| uninstall.go | 3 years ago | |
| use.go | 3 years ago | |
| version.go | 3 years ago | |