From 66aa7bf80a7fc8ad159e0c42036ce963761deafe Mon Sep 17 00:00:00 2001
From: defelmnq <defelmnq+github@gmail.com>
Date: Wed, 11 Dec 2024 00:06:06 +0100
Subject: [PATCH] add validation rules to monitoring variables

---
 monitoring/main.tf | 31 ++++++++++++++++++++++++-------
 1 file changed, 24 insertions(+), 7 deletions(-)

diff --git a/monitoring/main.tf b/monitoring/main.tf
index 112872e..7e85c21 100644
--- a/monitoring/main.tf
+++ b/monitoring/main.tf
@@ -9,27 +9,34 @@ terraform {
   }
 }
 
-variable "description" {
-  default     = "Monitoring of workspace resources"
-  description = "Monitoring of workspace resources"
-}
-
 variable "threshold" {
   type        = number
   description = "The threshold for the monitoring, used for all resources unless overridden by *_threshold - expressed as a percentage."
   default     = 90
+  validation {
+    condition     = var.threshold >= 0 && var.threshold <= 100
+    error_message = "The threshold must be between 0 and 100."
+  }
 }
 
 variable "memory_threshold" {
   type        = number
   description = "The threshold for the memory monitoring - expressed as a percentage."
   default     = 90
+  validation {
+    condition     = var.memory_threshold >= 0 && var.memory_threshold <= 100
+    error_message = "The memory_threshold must be between 0 and 100."
+  }
 }
 
 variable "disk_threshold" {
   type        = number
   description = "The threshold for the disk monitoring - expressed as a percentage."
   default     = 90
+  validation {
+    condition     = var.disk_threshold >= 0 && var.disk_threshold <= 100
+    error_message = "The disk_threshold must be between 0 and 100."
+  }
 }
 
 variable "disks" {
@@ -42,18 +49,30 @@ variable "enabled" {
   type        = bool
   description = "Whether the monitoring is enabled."
   default     = true
+  validation {
+    condition     = var.enabled == true || var.enabled == false
+    error_message = "The enabled must be true or false."
+  }
 }
 
 variable "memory_enabled" {
   type        = bool
   description = "Whether the memory monitoring is enabled."
   default     = true
+  validation {
+    condition     = var.memory_enabled == true || var.memory_enabled == false
+    error_message = "The memory_enabled must be true or false."
+  }
 }
 
 variable "disk_enabled" {
   type        = bool
   description = "Whether the disk monitoring is enabled."
   default     = true
+  validation {
+    condition     = var.disk_enabled == true || var.disk_enabled == false
+    error_message = "The disk_enabled must be true or false."
+  }
 }
 
 variable "agent_id" {
@@ -62,8 +81,6 @@ variable "agent_id" {
 }
 
 data "coder_monitoring" "monitoring" {
-  name         = "monitoring"
-  description  = var.description
   threshold    = var.threshold
   memory_threshold = var.memory_threshold
   disk_threshold = var.disk_threshold