diff --git a/jupyterlab/main.tf b/jupyterlab/main.tf index 25a9f3d..239c5aa 100644 --- a/jupyterlab/main.tf +++ b/jupyterlab/main.tf @@ -65,7 +65,7 @@ resource "coder_script" "jupyterlab" { resource "coder_app" "jupyterlab" { agent_id = var.agent_id - slug = "jupyterlab" # sync with with end of subdomain URL + slug = "jupyterlab" # sync with the usage in URL display_name = "JupyterLab" url = var.subdomain ? "http://localhost:${var.port}/@${data.coder_workspace_owner.me.name}/${data.coder_workspace.me.name}/apps/jupyterlab" : "http://localhost:${var.port}" icon = "/icon/jupyter.svg" diff --git a/jupyterlab/run.sh b/jupyterlab/run.sh index db9ab51..1cae1db 100755 --- a/jupyterlab/run.sh +++ b/jupyterlab/run.sh @@ -1,6 +1,6 @@ #!/usr/bin/env sh -if [ -n "$BASE_URL" ] +if [ -n "${BASE_URL}" ] then BASE_URL="--ServerApp.base_url=${BASE_URL}" fi @@ -25,8 +25,8 @@ else printf "%s\n\n" "🥳 jupyterlab is already installed" fi -echo "👷 Starting jupyterlab in background..." -echo "check logs at ${LOG_PATH}" +printf "👷 Starting jupyterlab in background..." +printf "check logs at ${LOG_PATH}" $HOME/.local/bin/jupyter-lab --no-browser \ "$BASE_URL" \ --ServerApp.ip='*' \