From c068082e6b2b5e080e391d5570b40455dcc7f8e7 Mon Sep 17 00:00:00 2001 From: Garrett Delfosse Date: Thu, 2 May 2024 13:03:58 -0400 Subject: [PATCH] pr comments --- CONTRIBUTING.md | 2 +- github-upload-public-key/run.sh | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 749791f..557171e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -10,7 +10,7 @@ To create a new module, clone this repository and run: A suite of test-helpers exists to run `terraform apply` on modules with variables, and test script output against containers. -The testing suite must be able to run docker containers with the `--network=host` flag, which typically requires running the tests on linux as this flag does not apply to Docker Desktop for MacOS and Windows. MacOS users can work around this by using something like [Orbstack](https://orbstack.dev/) instead of Docker Desktop. +The testing suite must be able to run docker containers with the `--network=host` flag, which typically requires running the tests on Linux as this flag does not apply to Docker Desktop for MacOS and Windows. MacOS users can work around this by using something like [colima](https://github.com/abiosoft/colima) or [Orbstack](https://orbstack.dev/) instead of Docker Desktop. Reference existing `*.test.ts` files for implementation. diff --git a/github-upload-public-key/run.sh b/github-upload-public-key/run.sh index 9083040..da39e10 100755 --- a/github-upload-public-key/run.sh +++ b/github-upload-public-key/run.sh @@ -3,22 +3,22 @@ set -e if [ -z "$CODER_ACCESS_URL" ]; then - echo "No CODER_ACCESS_URL specified!" + echo "CODER_ACCESS_URL is empty!" exit 1 fi if [ -z "$CODER_OWNER_SESSION_TOKEN" ]; then - echo "No CODER_OWNER_SESSION_TOKEN specified!" + echo "CODER_OWNER_SESSION_TOKEN is empty!" exit 1 fi if [ -z "$CODER_EXTERNAL_AUTH_ID" ]; then - echo "No CODER_EXTERNAL_AUTH_ID specified!" + echo "CODER_EXTERNAL_AUTH_ID is empty!" exit 1 fi if [ -z "$GITHUB_API_URL" ]; then - echo "No GITHUB_API_URL specified!" + echo "GITHUB_API_URL is empty!" exit 1 fi