From f5ae1d2ddf753e6fc6ef7217f1129077eaba66e2 Mon Sep 17 00:00:00 2001 From: Muhammad Atif Ali Date: Mon, 27 Nov 2023 13:52:21 +0300 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Mathias Fredriksson --- vault-github/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vault-github/README.md b/vault-github/README.md index cacf6f6..76550cf 100644 --- a/vault-github/README.md +++ b/vault-github/README.md @@ -9,7 +9,7 @@ tags: [helper, integration, vault, github] # Hashicorp Vault Integration (GitHub) -This module lets you authenticate with [Hashicorp Vault](https://www.vaultproject.io/) in your Coder workspaces using GitHub [external auth](https://coder.com/docs/v2/latest/admin/external-auth). +This module lets you authenticate with [Hashicorp Vault](https://www.vaultproject.io/) in your Coder workspaces using [external auth](https://coder.com/docs/v2/latest/admin/external-auth) for GitHub. ```hcl module "vault" { @@ -28,7 +28,7 @@ vault kv get -mount=secret my-secret or using the Vault API: ```shell -curl -H "X-Vault-Token: $VAULT_TOKEN" -X GET $VAULT_ADDR/v1/secret/data/my-secret +curl -H "X-Vault-Token: ${VAULT_TOKEN}" -X GET "${VAULT_ADDR}/v1/secret/data/my-secret" ``` ![Vault login](../.images/vault-login.png)