fix: minor linting issues

pull/106/head
Jeff Culverhouse 3 months ago
parent 2d48726917
commit e709760971

@ -26,11 +26,7 @@ class AmcrestMixin:
device_name = device.get("device_name", "unknown") device_name = device.get("device_name", "unknown")
device_id = device.get("serial_number", "unknown") device_id = device.get("serial_number", "unknown")
exception_type = type(result).__name__ exception_type = type(result).__name__
self.logger.error( self.logger.error(f"error during build_component for device '{device_name}' ({device_id}): " f"{exception_type}: {result}", exc_info=True)
f"error during build_component for device '{device_name}' ({device_id}): "
f"{exception_type}: {result}",
exc_info=True
)
elif result and isinstance(result, str): elif result and isinstance(result, str):
seen_devices.add(result) seen_devices.add(result)

@ -1,6 +1,5 @@
# SPDX-License-Identifier: MIT # SPDX-License-Identifier: MIT
# Copyright (c) 2025 Jeff Culverhouse # Copyright (c) 2025 Jeff Culverhouse
import re
from amcrest import AmcrestCamera, ApiWrapper from amcrest import AmcrestCamera, ApiWrapper
from amcrest.exceptions import LoginError, AmcrestError, CommError from amcrest.exceptions import LoginError, AmcrestError, CommError
import asyncio import asyncio
@ -13,6 +12,7 @@ from typing import TYPE_CHECKING, Any, cast
if TYPE_CHECKING: if TYPE_CHECKING:
from amcrest2mqtt.interface import AmcrestServiceProtocol as Amcrest2Mqtt from amcrest2mqtt.interface import AmcrestServiceProtocol as Amcrest2Mqtt
class AmcrestAPIMixin: class AmcrestAPIMixin:
def increase_api_calls(self: Amcrest2Mqtt) -> None: def increase_api_calls(self: Amcrest2Mqtt) -> None:
if not self.last_call_date or self.last_call_date.date() != datetime.now().date(): if not self.last_call_date or self.last_call_date.date() != datetime.now().date():
@ -192,11 +192,15 @@ class AmcrestAPIMixin:
states = self.states[device_id] states = self.states[device_id]
# return our last known state if something fails # return our last known state if something fails
current: dict[str, str | float] = { current: dict[str, str | float] = (
{
"used_percent": states["sensor"]["storage_used_pct"], "used_percent": states["sensor"]["storage_used_pct"],
"used": states["sensor"]["storage_used"], "used": states["sensor"]["storage_used"],
"total": states["sensor"]["storage_total"], "total": states["sensor"]["storage_total"],
} if "sensor" in states else {} }
if "sensor" in states
else {}
)
if not device["camera"]: if not device["camera"]:
self.logger.warning(f"camera not found for {self.get_device_name(device_id)}") self.logger.warning(f"camera not found for {self.get_device_name(device_id)}")
@ -265,7 +269,7 @@ class AmcrestAPIMixin:
self.logger.warning(f"failed to get privacy mode from ({self.get_device_name(device_id)}), got: {type(privacy)} with value: {privacy}") self.logger.warning(f"failed to get privacy mode from ({self.get_device_name(device_id)}), got: {type(privacy)} with value: {privacy}")
return current return current
privacy_mode = enable_value.lower() == "true" privacy_mode = bool(enable_value.lower() == "true")
return privacy_mode return privacy_mode
async def set_privacy_mode(self: Amcrest2Mqtt, device_id: str, switch: bool) -> None: async def set_privacy_mode(self: Amcrest2Mqtt, device_id: str, switch: bool) -> None:

Loading…
Cancel
Save