suggestions from review

pull/115/head
Muhammad Atif Ali 2 years ago
parent 3308bf1c6b
commit b1e182f152

@ -115,9 +115,9 @@ module "jfrog" {
agent_id = coder_agent.example.id agent_id = coder_agent.example.id
jfrog_url = "https://jfrog.example.com" jfrog_url = "https://jfrog.example.com"
username_field = "username" # If you are using GitHub to login to both Coder and Artifactory, use username_field = "username" username_field = "username" # If you are using GitHub to login to both Coder and Artifactory, use username_field = "username"
configure_code_server = true configure_code_server = true # Add JFrog extension configuration for code-server
package_managers = { package_managers = {
"npm": "npm",Add JFrog extension configuration for code-server "npm": "npm",
"go": "go", "go": "go",
"pypi": "pypi" "pypi": "pypi"
} }

@ -42,7 +42,7 @@ variable "agent_id" {
variable "configure_code_server" { variable "configure_code_server" {
type = bool type = bool
description = "Whether to configure code-server to use JFrog." description = "Set to true to configure code-server to use JFrog."
default = false default = false
} }

@ -82,9 +82,9 @@ module "jfrog" {
agent_id = coder_agent.example.id agent_id = coder_agent.example.id
jfrog_url = "https://XXXX.jfrog.io" jfrog_url = "https://XXXX.jfrog.io"
artifactory_access_token = var.artifactory_access_token artifactory_access_token = var.artifactory_access_token
configure_code_server = true configure_code_server = true # Add JFrog extension configuration for code-server
package_managers = { package_managers = {
"npm": "npm",Add JFrog extension configuration for code-server "npm": "npm",
"go": "go", "go": "go",
"pypi": "pypi" "pypi": "pypi"
} }

@ -63,7 +63,7 @@ variable "agent_id" {
variable "configure_code_server" { variable "configure_code_server" {
type = bool type = bool
description = "Whether to configure code-server to use JFrog." description = "Set to true to configure code-server to use JFrog."
default = false default = false
} }

Loading…
Cancel
Save