review suggestions

vault-github/run.sh

@@ -1,4 +1,4 @@
-#!/usr/bin/env sh
+#!/usr/bin/env bash
 
 # Convert all templated variables to shell variables
 INSTALL_VERSION=${INSTALL_VERSION}
@@ -31,15 +31,16 @@ unzip() {
   fi
 }
 
+install() {
   # Fetch the latest version of Vault if INSTALL_VERSION is 'latest'
   if [ "$${INSTALL_VERSION}" = "latest" ]; then
     LATEST_VERSION=$(curl -s https://releases.hashicorp.com/vault/ | grep -oP 'vault/\K[0-9]+\.[0-9]+\.[0-9]+' | sort -V | tail -n 1)
     printf "Latest version of Vault is %s.\n\n" "$${LATEST_VERSION}"
     if [ -z "$${LATEST_VERSION}" ]; then
       printf "Failed to determine the latest Vault version.\n"
-    exit 1
+      return 1
     fi
-  VERSION=$${LATEST_VERSION}
+    INSTALL_VERSION=$${LATEST_VERSION}
   fi
 
   # Check if the vault CLI is installed and has the correct version
@@ -57,31 +58,38 @@ if [ $${installation_needed} -eq 1 ]; then
     if [ -z "$${CURRENT_VERSION}" ]; then
       printf "Installing Vault CLI ...\n\n"
     else
-    printf "Upgrading Vault CLI from version %s to %s ...\n\n" "$${CURRENT_VERSION}" "$${VERSION}"
+      printf "Upgrading Vault CLI from version %s to %s ...\n\n" "$${CURRENT_VERSION}" "${INSTALL_VERSION}"
     fi
-  fetch vault.zip "https://releases.hashicorp.com/vault/$${VERSION}/vault_$${VERSION}_linux_amd64.zip"
+    fetch vault.zip "https://releases.hashicorp.com/vault/$${INSTALL_VERSION}/vault_$${INSTALL_VERSION}_linux_amd64.zip"
     if [ $? -ne 0 ]; then
       printf "Failed to download Vault.\n"
-    exit 1
+      return 1
     fi
-  unzip vault.zip
+    if ! unzip_safe vault.zip; then
-  if [ $? -ne 0 ]; then
       printf "Failed to unzip Vault.\n"
-    exit 1
+      return 1
     fi
     rm vault.zip
     if sudo mv vault /usr/local/bin/vault 2> /dev/null; then
       printf "Vault installed successfully!\n\n"
     else
       mkdir -p ~/.local/bin
-    mv vault ~/.local/bin/vault
+      if ! mv vault ~/.local/bin/vault; then
-    if [ ! -f ~/.local/bin/vault ]; then
         printf "Failed to move Vault to local bin.\n"
-      exit 1
+        return 1
       fi
       printf "Please add ~/.local/bin to your PATH to use vault CLI.\n"
     fi
   fi
+}
+
+TMP=$(mktemp -d)
+pushd "${TMP}" > /dev/null
+if ! install; then
+  printf "Installation failed\n"
+fi
+popd > /dev/null
+rm -rf "${TMP}"
 
 # Authenticate with Vault
 printf "🔑 Authenticating with Vault ...\n\n"